Skip to content

Fix cargo doc not generate dependencies type document#3954

Merged
zhangsoledad merged 3 commits intonervosnetwork:developfrom
eval-exec:fix/rpc-doc
Apr 23, 2023
Merged

Fix cargo doc not generate dependencies type document#3954
zhangsoledad merged 3 commits intonervosnetwork:developfrom
eval-exec:fix/rpc-doc

Conversation

@eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Apr 23, 2023

What problem does this PR solve?

Issue Number: close #3951

Problem Summary:
To avoid potential race conditions, it is recommended to generate documentation for all members in the workspace using the command cargo doc --workspace.

What is changed and how it works?

What's Changed:

Related changes

  • use cargo doc --workspace to generate all crates' documents.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

None: Exclude this PR from the release note.

@eval-exec eval-exec marked this pull request as ready for review April 23, 2023 09:05
@eval-exec eval-exec requested a review from a team as a code owner April 23, 2023 09:05
@eval-exec eval-exec requested review from quake and removed request for a team April 23, 2023 09:05
@eval-exec eval-exec added t:ci Type: CI t:doc Type: Documentation labels Apr 23, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Apr 23, 2023
Merged via the queue into nervosnetwork:develop with commit 880ef05 Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:ci Type: CI t:doc Type: Documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Type discrepancy in DeploymentInfo between codebase and rpc/README.md documentation

3 participants