Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: batch changes to syscall bindings #35

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

XuJiandong
Copy link
Collaborator

@XuJiandong XuJiandong commented Jan 14, 2025

  • The positions of offset and length are reversed; currently, length is followed by offset, which does not align with common conventions.
  • The naming in JavaScript uses snake_case, but it should be changed to camelCase.
  • In some places, JS_ToInt64 is used, which does not throw an exception on error. The types should be checked.
  • Define all error codes in a single file and provide documentation comments.
  • Ensure js_module_set_import_meta is set correctly.
  • Remove dependency of nncp

@XuJiandong XuJiandong merged commit 5d4cbb6 into nervosnetwork:main Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant