Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crop obb masking in pointcloud generation #3433

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

nepfaff
Copy link
Contributor

@nepfaff nepfaff commented Sep 16, 2024

The same mask was used twice when crop_obb was None. This led to indexing errors.

I would provide example data but it should make sense when reading the code from line 158.

Copy link
Collaborator

@jb-ye jb-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jb-ye jb-ye merged commit 27b8e14 into nerfstudio-project:main Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants