Adding Random Seed for Frame Processing #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthony-Tafoya
force-pushed
the
Anthony/Random-Seed-Processing
branch
from
be44674
to
acb4007
Compare
Anthony-Tafoya
changed the title
Anthony-Tafoya
force-pushed
the
Anthony/Random-Seed-Processing
branch
from
28ba7d7
to
aff0083
Compare
Anthony-Tafoya
force-pushed
the
Anthony/Random-Seed-Processing
branch
from
aff0083
to
489fb68
Compare
jb-ye
reviewed
Sep 16, 2024
| random.seed(random_seed) | ||
| frame_indices = sorted(random.sample(range(num_frames), num_frames_target)) | ||
| select_cmd = "select='" + "+".join([f"eq(n\,{idx})" for idx in frame_indices]) + "',setpts=N/TB," | ||
| CONSOLE.print(f"Extracting {num_frames_target} frames using seed-based random selection.") |
There was a problem hiding this comment.
Could u also print the random_seed here as well?
| frame_indices = sorted(random.sample(range(num_frames), num_frames_target)) | ||
| select_cmd = "select='" + "+".join([f"eq(n\,{idx})" for idx in frame_indices]) + "',setpts=N/TB," | ||
| CONSOLE.print(f"Extracting {num_frames_target} frames using seed-based random selection.") | ||
| elif spacing > 1: | ||
| CONSOLE.print("Number of frames to extract:", math.ceil(num_frames / spacing)) |
There was a problem hiding this comment.
Could you also make the print log more clear that the extracted frame is evenly spacing?
| @@ -41,6 +41,10 @@ class VideoToNerfstudioDataset(ColmapConverterToNerfstudioDataset): | |||
| """Feature matching method to use. Vocab tree is recommended for a balance of speed | |||
| and accuracy. Exhaustive is slower but more accurate. Sequential is faster but | |||
| should only be used for videos.""" | |||
| random_seed: Optional[int] = None | |||
| """Random seed to select video frames""" | |||
There was a problem hiding this comment.
Is this random seed for select training set? maybe make it more clear in the comments
jb-ye
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to the Issue #3048
Background: Currently, frame processing video logic works by sampling N frames from N evenly spaced intervals throughout the video. Although a worthy method, researchers should be allowed to choose frames from a random seed to produce more consistent results.
This PR implements optional --random_seed and --eval_random_seed flags for the ns-process-data video in case a specific seed is requested.
Verification Evidence: Placed a video and a random seed to produce a consistent result
Here is the result
Unit Tests: A function to test_misc that confirms that the random_seed processes the number of frames correctly.
Future Work: After this alternative, finding ways to choose frames based on blurriness and other forms of visual change is necessary. Create an integration test with ns-process-data video since there is only one for image currently.