Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera models #2997

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Camera models #2997

merged 2 commits into from
Mar 11, 2024

Conversation

wooni-github
Copy link
Contributor

delete space "simple_pinhole": CameraModel.SIMPLE_PINHOLE,

Copy link
Collaborator

@maturk maturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Next time, you can directly push to your previous PR branch, since making a new PR is not necessary. But now the Ruff formatter is happy.

@maturk maturk merged commit 9960de0 into nerfstudio-project:main Mar 11, 2024
2 checks passed
@wooni-github
Copy link
Contributor Author

Actually I'm not familiar with PR, so I did it in a strange way! Thank you for the comment.

@maturk
Copy link
Collaborator

maturk commented Mar 11, 2024

@wooni-github no problem.

Michael-Spleenlab pushed a commit to Michael-Spleenlab/nerfstudio that referenced this pull request Apr 26, 2024
ArpegorPSGH pushed a commit to ArpegorPSGH/nerfstudio that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants