Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nerfacto + Aria #2950

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Fix Nerfacto + Aria #2950

merged 2 commits into from
Feb 26, 2024

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Feb 23, 2024

#2783 fixed an issue where the fisheye_crop_radius metadata field was being accidentally deleted. Unfortunately this also broke nerfacto support for Aria, since it exposed some broken fisheye sampling logic from #2617 (which was previously not being run).

Specific fixed problems:

  • Sampled x/y coordinates were unnecessarily scaled by image_height // 2 and image_width // 2, since the crop radius is already in pixel units.
  • The circle crop typically exceeds the bounds of the image, so sampling from the circle naively still has issues. We fix this with rejection sampling.

These changes + #2783 reduce artifacts.

Before:

aria-nerfstudio-render.mp4

After:

2024-02-22-21-27-52.mp4

Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@kerrj kerrj enabled auto-merge (squash) February 26, 2024 18:03
@kerrj kerrj merged commit c491e3e into main Feb 26, 2024
2 checks passed
@kerrj kerrj deleted the brent/aria_nerfacto_fix branch February 26, 2024 18:16
Michael-Spleenlab pushed a commit to Michael-Spleenlab/nerfstudio that referenced this pull request Apr 26, 2024
ArpegorPSGH pushed a commit to ArpegorPSGH/nerfstudio that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants