Add Mill 19 dataset #2742
Merged
Add Mill 19 dataset #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentyi
reviewed
Jan 10, 2024
|
|
||
| capture_name: Mill19CaptureName = "building" | ||
|
|
||
| def download(self, save_dir: Path): |
There was a problem hiding this comment.
(nit) this could use a return annotation -> None
| ), f"Capture name {self.capture_name} not found in {mill19_downloads.keys()}" | ||
| url = mill19_downloads[self.capture_name] | ||
| target_path = str(save_dir / f"mill19/{self.capture_name}") | ||
| os.makedirs(target_path, exist_ok=True) |
There was a problem hiding this comment.
can we use the pathlib API for these operations instead? like:
target_path = save_dir / ...
target_path.mkdir(exist_ok=True)
same for replacing os.listdir(), os.path.join(), etc below
brentyi
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Mill 19 dataset to the ns-download-data script and converts it to the format that the nerfstudio data parser expects: