fix the bugs associated with blender datas #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it with lego, seems that gsplat trys hard to learn the background colour. setting background in nerfstudio\models\gaussian_splatting.py the same as blender bg colour fixs this. I forced overwriting the bg color, but it is super inelegant. |
KevinXu02
changed the title
… into convert-cameras-json
… into convert-cameras-json
|
It seems that my ruff formatter keeps messing everything up, but the background should work now. When using blender data the background_color should be changed to white to avoid cloulds. In the viser the rendered bg color is always overwritten to grey, it will not affect training, but I wonder if there is some way to modify it without using overwrite. |
|
Hi everyone! How can I change the background color to white? I tried doing this, but I kept getting some strange visualizations |
ArpegorPSGH
pushed a commit
to ArpegorPSGH/nerfstudio
that referenced
this pull request
Jun 22, 2024
* fix the bug when camera.distortion_params is None * Handle background color override when using blender. * fix bare except * format * Update background color override in Blender dataparser * Add ability to download EyefulTower dataset * wip before I copy linning's stuff in * Generate per-resolution cameras.xml * Generate transforms.json at download * Fix a couple of quotes * Use official EyefulTower splits for train and val * Disable projectaria-tools on windows * Fix extra imports * Add a new nerfacto method tund for EyefulTower * Split eyefultower download into a separate file * Fix typo * Add some fisheye support for eyeful data * Reformatted imports to not be dumb * Apparently this file was missed when formatting originally * Added 1k resolution scenes * revert method_configs.py to original values * Also add 1k exrs * Add option to modify bg color in gaussian splatting * fix back the config, bg color should work now * removed camera optimizer for gs to align with main * Address feedback * Revert changes to pyproject.toml, to be added in a later PR * Oops, probably shouldn't have gotten rid of awscli ... * adding support for bg color, tested and reformatted now * formatted * formatted * changed glob variable name * Refactor background color variable name * prevent viser overriding --------- Co-authored-by: Vasu Agrawal <vasuagrawal@meta.com> Co-authored-by: Ethan Weber <ethanweber@berkeley.edu> Co-authored-by: Brent Yi <yibrenth@gmail.com> Co-authored-by: Justin Kerr <justin.g.kerr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the bug when camera.distortion_params is None, which will lead to no data when using blender data.