add Artifacts links github action #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdCopter
added a commit
that referenced
this pull request
Oct 24, 2025
Fixes 3 issues from CodeRabbitAI review: 1. cli_unittest.cc: Use writable char arrays instead of casting string literals to char*. Prevents undefined behavior when cliVtx() mutates the buffer (string literals are read-only on most platforms). Fixed 5 instances. 2. vtx_unittest.cc: Fix memset() to zero the struct, not the pointer address. Was using memset(&cac, ...) instead of memset(cac, ...). Also use vtxConfigMutable() and remove const. 3. telemetry_ghst_unittest.cc: Change getEstimatedAltitude() return type from uint32_t to int32_t. Altitude can be negative (below sea level) and other tests expect signed. Add void parameter. All tests pass (38/38 PASS, 2 DISABLED). Resolves PR review outside diff range comments #3, #4, #5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.