-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added expand
flag to stringify_unsupported()
to expand series
#1862
Conversation
stringify_unsupported()
now expands listsexpand
flag to stringify_unsupported()
to expand series
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/1.x #1862 +/- ##
===========================================
- Coverage 77.56% 75.59% -1.97%
===========================================
Files 303 303
Lines 15382 15366 -16
===========================================
- Hits 11931 11616 -315
- Misses 3451 3750 +299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need a better explanation, apart from that LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for @normandy7's approval then it's good to merge
Co-authored-by: Sabine Ståhlberg <sabine.nyholm@neptune.ai>
Before submitting checklist
stringify_unsupported()
does not currently expand lists, casting them to string instead.For dicts that contain lists as values, as shown below
this leads to keys like
projects
,skills
, andemployment_history
being logged as a stringExample
This makes it harder to find relevant information if it is nested as a list in a dict, and also makes it a lot harder to download such metadata from Neptune, as it would be downloaded as a string.
This PR adds an optional
expand
flag tostringify_unsupported()
to expand series like lists, sets, and tuples thereby storing nested values in their proper folder structure within enumerated folders, making it easier to both search for metadata and download it.Example