updates the environment variables table to login to dockerhub #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/hold |
Member
electrocucaracha
left a comment
electrocucaracha
left a comment
There was a problem hiding this comment.
Let's sync this change until the another PR gets merged
Contributor
Author
|
/hold cancel |
Member
|
/lgtm |
Member
|
@vjayaramrh could you rebase this patch for merging it? |
vjayaramrh
force-pushed
the
dockerhub_support
branch
from
abc06f4 to
60b2682
Compare
Contributor
Author
Thanks @electrocucaracha , Its rebased now. |
Member
|
/lgtm |
Contributor
Author
|
@johnbelamaric @henderiw Could one of you review and merge? Thanks |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: henderiw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the changes made in nephio-project/test-infra#182