Skip to content

Improve manual e2e testing#38

Merged
nephio-prow[bot] merged 3 commits intonephio-project:mainfrom
matysiaq:improve-manual-e2e-testing
Jul 5, 2023
Merged

Improve manual e2e testing#38
nephio-prow[bot] merged 3 commits intonephio-project:mainfrom
matysiaq:improve-manual-e2e-testing

Conversation

@matysiaq
Copy link
Contributor

@matysiaq matysiaq commented Jul 4, 2023

When following step-by-step manual, there are few issues which may lead to the major problems when trying to test the connectivity. Here I try to resolve them.

matysiaq added 3 commits July 4, 2023 09:06
…tion

While using `test-infra/e2e/tests/003.sh` appropriate secret is created, which is not the case for the step-by-step guide, which leads to the connectivity issues.
Using ` --skip-post-deploy` flag in the `containerlab deploy` command leads to the `context deadline exceeded` in the network-config-controller
When following step-by-step manual, we never create `regional-kubeconfig` in the home directory. To make sure that it will not fail, we can copy it before starting new ssh connection.
@nephio-prow nephio-prow bot requested review from s3wong and tliron July 4, 2023 07:39
@johnbelamaric
Copy link
Member

/approve
/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jul 5, 2023
@nephio-prow nephio-prow bot merged commit 8a220e2 into nephio-project:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants