Skip to content

Conversation

@liamfallon
Copy link
Member

No description provided.

@nephio-prow nephio-prow bot requested review from johnbelamaric and tliron June 26, 2023 17:04
@liamfallon
Copy link
Member Author

/assign @henderiw @efiacor @lapentad

```

6. The `data.name` field in `package-context.yaml` files in sub kpt packages is changed to be the name of the sub package
7. All other sub-fields under the `data:` field are deleted
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder is this a bug in kpt?

@johnbelamaric
Copy link
Member

I am going to merge all these and we will iterate from here.

/approve
/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 27, 2023
@nephio-prow nephio-prow bot merged commit 01bc2bf into nephio-project:main Jun 27, 2023
@liamfallon liamfallon deleted the package-transf branch June 27, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants