Explore sandbox by liamfallon · Pull Request #24 · nephio-project/docs

liamfallon · 2023-06-20T12:52:27Z

No description provided.

Signed-off-by: liamfallon <liam.fallon@est.tech>

liamfallon · 2023-06-20T12:53:34Z

/assign @electrocucaracha @efiacor @lapentad @henderiw

lapentad

Is the .drawio file supposed to be there?

liamfallon · 2023-06-20T13:02:53Z

@lapentad yes, it's the draw.io source file that the .png was generated from. It's there so that the diagram can be modified later.

electrocucaracha

Great work @liamfallon, thanks for capturing and describing the process. I just found a typo, besides that everything looks good.

electrocucaracha · 2023-06-20T16:50:44Z

install-guide/ExploreSandbox.md

+ <summary>You can check the status of an applied kpt package using a "kpt live status package_dir" command.</summary>
+
+```
+sudo kpt live status /tmp/kpt-pkg/nephio-controllers/


This PR will allow running things without sudo. We can merge this document as it is and change it once the other PR is approved.

Suggested change

sudo kpt live status /tmp/kpt-pkg/nephio-controllers/

kpt live status /tmp/kpt-pkg/nephio-controllers/

electrocucaracha · 2023-06-20T16:50:54Z

install-guide/ExploreSandbox.md

+| Postgres     | Used by Gitea to store repositories                                |
+| Cluster CAPI | Used deploy kind workload clusters                                 |
+| IPAM         | A system used to allocate and manage IP addresses                  |
+| VLAM         | A system used to allocate and manage VLANs                         |


efiacor

Minor suggested edit. Overall looks very helpful.

efiacor · 2023-06-20T20:49:51Z

install-guide/ExploreSandbox.md

+<summary>Querying the k8s pods running after the install produces output similar to:</summary>
+
+```
+$ kubectl get pods -A


Slight improvement if you don't need the kube-system pods

kubectl get pods -A --field-selector=metadata.namespace!=kube-system

lapentad · 2023-06-21T08:51:06Z

learning.md

 * [https://github.com/Orange-OpenSource/towards5gs-helm](https://github.com/Orange-OpenSource/towards5gs-helm): Reference helm charts from Orange for the Free5gc core network NFs and for the UERANSIM Radio Access Network
 * [https://github.com/matysiaq/kpt-packages-catalog](https://github.com/matysiaq/kpt-packages-catalog): Custom kpt packages for free5gc and UERANSIM from Orange
-* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved f5ee5gc operator from Orange
+* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved f5ee5gc operator from Orange


Suggested change

* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved f5ee5gc operator from Orange

* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved free5gc operator from Orange

electrocucaracha · 2023-06-21T13:39:52Z

/lgtm

gvbalaji

Thanks @liamfallon for the nice write up. Added couple of comments.

gvbalaji · 2023-06-22T10:49:02Z

install-guide/ExploreSandbox.md

+
+## Base Components
+
+The following base components are installed on the kind management cluster. Base components are standard components in the k8s ecosystem, which Nephio uses out of the box.


Instead of saying "Base components are standard components in the k8s ecosystem," we could say "Base components are the infrastructure components that are needed for the Nephio sandbox"

@gvbalaji I reworded the document along the lines you suggested.

gvbalaji · 2023-06-22T11:22:08Z

install-guide/ExploreSandbox.md

+| Gitea        | Used to allow creation and management of local git repos by Nephio |
+| Postgres     | Used by Gitea to store repositories                                |
+| Cluster CAPI | Used deploy kind workload clusters                                 |
+| IPAM         | A system used to allocate and manage IP addresses                  |


IPAM and VLAN backends are more like reference implementations that we use. In real world customers may use something else.

I updated this as well.

liamfallon · 2023-06-23T09:11:01Z

Could we nudge this on please?

henderiw · 2023-06-23T11:48:51Z

/lgtm
/approve

nephio-prow · 2023-06-23T11:48:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, henderiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [henderiw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

liamfallon added 2 commits June 20, 2023 13:44

Add document exploring management cluster

2113daf

mend

3edb61e

Signed-off-by: liamfallon <liam.fallon@est.tech>

nephio-prow bot requested review from s3wong and tliron June 20, 2023 12:52

nephio-prow bot assigned efiacor, electrocucaracha, henderiw and lapentad Jun 20, 2023

lapentad reviewed Jun 20, 2023

View reviewed changes

electrocucaracha suggested changes Jun 20, 2023

View reviewed changes

efiacor approved these changes Jun 20, 2023

View reviewed changes

Fixed typos, added improvements suggested by reviews

e41fa81

lapentad reviewed Jun 21, 2023

View reviewed changes

Fix typo in learning.md

eef9be7

nephio-prow bot added the lgtm label Jun 21, 2023

gvbalaji reviewed Jun 22, 2023

View reviewed changes

Updated to address review comments

5963453

nephio-prow bot removed the lgtm label Jun 22, 2023

nephio-prow bot added the lgtm label Jun 23, 2023

nephio-prow bot added the approved label Jun 23, 2023

nephio-prow bot merged commit dab9687 into nephio-project:main Jun 23, 2023

liamfallon deleted the explore-sandbox branch June 26, 2023 16:59

	sudo kpt live status /tmp/kpt-pkg/nephio-controllers/
	kpt live status /tmp/kpt-pkg/nephio-controllers/

	\| VLAM \| A system used to allocate and manage VLANs \|
	\| VLAN \| A system used to allocate and manage VLANs \|

	* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved f5ee5gc operator from Orange
	* [https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator](https://github.com/matysiaq/nephio-pocs/tree/main/free5gc-operator): An improved free5gc operator from Orange


		## Base Components

		The following base components are installed on the kind management cluster. Base components are standard components in the k8s ecosystem, which Nephio uses out of the box.

Conversation

liamfallon commented Jun 20, 2023

Uh oh!

liamfallon commented Jun 20, 2023

Uh oh!

lapentad left a comment

Choose a reason for hiding this comment

Uh oh!

liamfallon commented Jun 20, 2023

Uh oh!

electrocucaracha left a comment

Choose a reason for hiding this comment

Uh oh!

electrocucaracha Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

efiacor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

electrocucaracha commented Jun 21, 2023

Uh oh!

gvbalaji left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liamfallon commented Jun 23, 2023

Uh oh!

henderiw commented Jun 23, 2023

Uh oh!

nephio-prow bot commented Jun 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

electrocucaracha Jun 20, 2023 •

edited

Loading