Skip to content

Conversation

@gkumar78
Copy link
Contributor

The corresponding change in Repository API spec is covered in following Porch PR
nephio-project/porch#179

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Feb 10, 2025

Hi @gkumar78. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 31cd705
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/67c098ba49d882000830a1ad
😎 Deploy Preview https://deploy-preview-205--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gkumar78
Copy link
Contributor Author

Fixes nephio-project/nephio#830

@efiacor
Copy link
Collaborator

efiacor commented Feb 25, 2025

@gkumar78 rebase required. Thanks

@gkumar78
Copy link
Contributor Author

@efiacor Looks like I have merged main into my gkumar78:remove-mutator-from-repository-spec branch; instead of rebasing. Should I abandon this PR and create new one?

@efiacor
Copy link
Collaborator

efiacor commented Feb 27, 2025

@efiacor Looks like I have merged main into my gkumar78:remove-mutator-from-repository-spec branch; instead of rebasing. Should I abandon this PR and create new one?

Should be fine to continue with this PR. Links need to be updated though -
https://github.com/nephio-project/docs/actions/runs/13546228585/job/37858398419?pr=205

@sonarqubecloud
Copy link

@gkumar78
Copy link
Contributor Author

Hi @efiacor, updated the url links and tested. Please squash into 1 commit while merging to keep the history clean

@efiacor
Copy link
Collaborator

efiacor commented Feb 27, 2025

/approve
/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Feb 27, 2025
@nephio-prow nephio-prow bot merged commit 42c8117 into nephio-project:main Feb 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants