Adding documentation for TLS registries configuration by Catalin-Stratulat-Ericsson · Pull Request #183 · nephio-project/docs

Catalin-Stratulat-Ericsson · 2024-11-13T10:31:22Z

Paired with PR#139

adds documentation for configuring custom CA certificate integration for private TLS registries

netlify · 2024-11-13T10:31:37Z

✅ Deploy Preview for nephio ready!

Name	Link
🔨 Latest commit	`f9dab9b`
🔍 Latest deploy log	https://app.netlify.com/sites/nephio/deploys/673def68614a9c0008b85035
😎 Deploy Preview	https://deploy-preview-183--nephio.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

content/en/docs/porch/using-porch/using-authenticated-private-registries.md

…registries.md Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>

CsatariGergely · 2024-11-13T16:35:05Z

/approve

JamesMcDermott

Mostly grammar and English nitpicking - couple of questions I may reiterate on the code PR

content/en/docs/porch/using-porch/using-authenticated-private-registries.md

…registries.md Co-authored-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

JamesMcDermott · 2024-11-18T14:22:48Z

/approve

liamfallon · 2024-11-19T07:47:21Z

content/en/docs/porch/using-porch/using-authenticated-private-registries.md

I think it would be better to cover each case in separate sections here, it's difficult to follow when the different configuraiton options are mixed together int he explanation.

…rity

content/en/docs/porch/using-porch/using-authenticated-private-registries.md

…registries.md Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>

liamfallon

/approve

kushnaidu · 2024-11-21T10:52:42Z

Looks good Catalin.
/approve

liamfallon · 2024-11-25T07:27:35Z

/approve
/lgtm

nephio-prow · 2024-11-25T07:27:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CsatariGergely, JamesMcDermott, kushnaidu, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [CsatariGergely,liamfallon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adding documentation for tls registries configuration

129fc0c

nephio-prow bot requested review from henderiw and s3wong November 13, 2024 10:31

Catalin-Stratulat-Ericsson mentioned this pull request Nov 13, 2024

Adding TLS configuration for fn-runner image registries nephio-project/porch#139

Merged

Catalin-Stratulat-Ericsson requested review from CsatariGergely, JamesMcDermott, efiacor, kispaljr, kushnaidu, liamfallon and nagygergo November 13, 2024 10:50

CsatariGergely suggested changes Nov 13, 2024

View reviewed changes

Catalin-Stratulat-Ericsson and others added 8 commits November 13, 2024 16:19

Update content/en/docs/porch/using-porch/using-authenticated-private-…

b620d7d

…registries.md Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

c7068b9

…registries.md Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

e823320

…registries.md Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

b187beb

…registries.md Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

cb93ae4

…registries.md Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

37d71f9

…registries.md Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

f911b95

…registries.md Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

90b38c3

…registries.md Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>

nephio-prow bot added the approved label Nov 13, 2024

JamesMcDermott reviewed Nov 14, 2024

View reviewed changes

Catalin-Stratulat-Ericsson and others added 3 commits November 18, 2024 10:01

Merge branch 'nephio-project:main' into tls-registries

4f4c91d

ammending syntax comments & added extra documentation on logic flow

48df676

added correct apostrophe

249fa69

JamesMcDermott reviewed Nov 18, 2024

View reviewed changes

content/en/docs/porch/using-porch/using-authenticated-private-registries.md Outdated Show resolved Hide resolved

content/en/docs/porch/using-porch/using-authenticated-private-registries.md Outdated Show resolved Hide resolved

JamesMcDermott reviewed Nov 18, 2024

View reviewed changes

content/en/docs/porch/using-porch/using-authenticated-private-registries.md Outdated Show resolved Hide resolved

content/en/docs/porch/using-porch/using-authenticated-private-registries.md Outdated Show resolved Hide resolved

JamesMcDermott reviewed Nov 18, 2024

View reviewed changes

content/en/docs/porch/using-porch/using-authenticated-private-registries.md Outdated Show resolved Hide resolved

Catalin-Stratulat-Ericsson and others added 3 commits November 18, 2024 14:04

Update content/en/docs/porch/using-porch/using-authenticated-private-…

b779bed

…registries.md Co-authored-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

57c1c4b

…registries.md Co-authored-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

401ebff

…registries.md Co-authored-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Catalin-Stratulat-Ericsson added 3 commits November 18, 2024 15:45

changed argument name and description to clarify logic

4f27def

removed typo

387d695

more argument renames for clarity

bdac5ba

liamfallon reviewed Nov 19, 2024

View reviewed changes

Catalin-Stratulat-Ericsson added 2 commits November 19, 2024 17:23

restructured function-runner private registries documentation for cla…

b0ed148

…rity

changed title to clarify which porch component its based on

a762acf

liamfallon reviewed Nov 20, 2024

View reviewed changes

content/en/docs/porch/using-porch/using-authenticated-private-registries.md Outdated Show resolved Hide resolved

liamfallon reviewed Nov 20, 2024

View reviewed changes

content/en/docs/porch/using-porch/using-authenticated-private-registries.md Outdated Show resolved Hide resolved

liamfallon reviewed Nov 20, 2024

View reviewed changes

content/en/docs/porch/using-porch/using-authenticated-private-registries.md Outdated Show resolved Hide resolved

liamfallon reviewed Nov 20, 2024

View reviewed changes

content/en/docs/porch/using-porch/using-authenticated-private-registries.md Outdated Show resolved Hide resolved

liamfallon reviewed Nov 20, 2024

View reviewed changes

content/en/docs/porch/using-porch/using-authenticated-private-registries.md Outdated Show resolved Hide resolved

Catalin-Stratulat-Ericsson and others added 7 commits November 20, 2024 14:00

Update content/en/docs/porch/using-porch/using-authenticated-private-…

0f91716

…registries.md Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

c8d56d3

…registries.md Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

5d4a5bf

…registries.md Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

fc54bbb

…registries.md Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>

Update content/en/docs/porch/using-porch/using-authenticated-private-…

06f7dc7

…registries.md Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>

removed unnecessary note section + added numbering to sections

3fd0e34

fixed broken section link

f9dab9b

liamfallon reviewed Nov 20, 2024

View reviewed changes

nephio-prow bot assigned liamfallon Nov 25, 2024

nephio-prow bot added the lgtm label Nov 25, 2024

nephio-prow bot merged commit a57d6ff into nephio-project:main Nov 25, 2024

Conversation

Catalin-Stratulat-Ericsson commented Nov 13, 2024

Uh oh!

netlify bot commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nephio ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CsatariGergely commented Nov 13, 2024

Uh oh!

JamesMcDermott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JamesMcDermott commented Nov 18, 2024

Uh oh!

liamfallon Nov 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liamfallon left a comment

Choose a reason for hiding this comment

Uh oh!

kushnaidu commented Nov 21, 2024

Uh oh!

liamfallon commented Nov 25, 2024

Uh oh!

nephio-prow bot commented Nov 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify bot commented Nov 13, 2024 •

edited

Loading