Add a note about minumum Go version #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
/assign @liamfallon @efiacor |
liamfallon
reviewed
Sep 5, 2024
liamfallon
reviewed
Sep 5, 2024
liamfallon
reviewed
Sep 5, 2024
Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>
Member
|
/approve |
Member
|
I think this PR needs a rebase. |
Member
|
/retest |
…ct#161) Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
It was removed in nephio-project/porch#107 Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Fixed in-line commands --------- Signed-off-by: Schweier Dominika <dominika.schweier@nokia.com> Signed-off-by: Dominika Schweier <dominika.schweier@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Now without a token Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Co-authored-by: Rado Chmiel <r.chmiel@partner.samsung.com>
Co-authored-by: Rado Chmiel <r.chmiel@partner.samsung.com>
Co-authored-by: Rado Chmiel <r.chmiel@partner.samsung.com>
…ing init.sh (nephio-project#173) This is a follow up on the work merged in nephio-project/catalog#72, updating the docs to reflect some prereqs needed for OCP. I think the OCP docs are still very much a work in progress, but this should at least make the docs for our contribution more consistent with test-infra and the catalog repos. resolve nephio-project/nephio#801
When the tutorial documentation was moved to the "docs" repo, we did not move the example config into the examples directory in the Porch repo. This PR updates the tutorial to refer to the location of the tutorial files. See also the porch update in this PR: nephio-project/porch#117
Contributor
Author
|
BANG! Merged main now. maybe a rebase would have been smarter in this case :) DO we have any policies for these in Nephio? |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
I don't think there are any policies around rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.