Skip to content

Conversation

@ciaranjohnston
Copy link
Member

As discussed in the architecture meeting on Friday, and again in the SIG Network Architecture meeting today, here is the PR for the architecture documentation in C4.

@netlify
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 3f7ed02
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/661e7b609262eb0009dfb9e3
😎 Deploy Preview https://deploy-preview-124--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ciaranjohnston ciaranjohnston marked this pull request as draft April 8, 2024 18:20
@liamfallon
Copy link
Member

/assign @adetalhouet

Copy link
Member

@liamfallon liamfallon Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text on this diagram is very small and I had to download the image locally to read it. Maybe I'm doing something wrong but when I downloaded the PR and browsed to the page in Hugo, the png file rendered.

ciaranjohnston and others added 3 commits April 15, 2024 17:35
Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>
Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>
@liamfallon
Copy link
Member

/approve

@nephio-prow nephio-prow bot added the approved label Apr 15, 2024
@ciaranjohnston ciaranjohnston marked this pull request as ready for review April 16, 2024 13:26
@nephio-prow nephio-prow bot requested review from efiacor and liamfallon April 16, 2024 13:26
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@adetalhouet adetalhouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although last update is from me.

@liamfallon
Copy link
Member

EasyCLA is blocking merge of PRs at the moment. A ticket has been raised with the LF: https://nephio.slack.com/archives/C03L6Q8LFHD/p1713270138006809

@efiacor
Copy link
Collaborator

efiacor commented Apr 16, 2024

/easycla

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@liamfallon
Copy link
Member

/lgtm

@liamfallon
Copy link
Member

/approve

@efiacor
Copy link
Collaborator

efiacor commented Apr 16, 2024

/lgtm
/approve

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adetalhouet, efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit e7e03db into nephio-project:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants