Skip to content

Conversation

@isu-kim
Copy link
Contributor

@isu-kim isu-kim commented Apr 3, 2024

According to playbook in test-infra for provisioning, enabling or disabling KinD cluster shall be achieved by
kind.enabled not kind.enable (reference).

However, the document had kind.enable which sets up a KinD cluster that overwrites the current kubeconfig which I had. This seems not to be an expected behavior.

- doc: fix invalid argument with Ansible
@nephio-prow nephio-prow bot requested review from johnbelamaric and s3wong April 3, 2024 01:01
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Apr 3, 2024

Hi @isu-kim. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit bda1986
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/660caa64efe8e800083a5a56
😎 Deploy Preview https://deploy-preview-122--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arora-sagar arora-sagar requested review from arora-sagar and removed request for johnbelamaric and s3wong April 11, 2024 15:22
@arora-sagar
Copy link
Contributor

@electrocucaracha Are you fine with this change? In the master branch, it is kind.enabled for test-infra.

@electrocucaracha
Copy link
Member

@electrocucaracha Are you fine with this change? In the master branch, it is kind.enabled for test-infra.

@arora-sagar that's correct, the default value is defined here

/lgtm

@electrocucaracha
Copy link
Member

@isu-kim could you sign the CLA or CCLA to be able to merge this change

@isu-kim
Copy link
Contributor Author

isu-kim commented Apr 13, 2024

@electrocucaracha I have just signed ICLA, since I am currently in a university lab that does not belong as a corporate.
If ICLA is not allowed, I will contact my supervisor for a reference for CCLA.

However, as mentioned in PR #120, I had no "details" button next to EasyCLA.
[reference below:]

@nyrahul Can you finish the EasyCLA process?

I think my EasyCLA is already done (since my PR in nephio repo is already merged and where I had followed that process). I think this PR is awaiting approval from maintainers before the easycla check can be done. Typically if the EasyCLA fails it provides the "details" link which is not provided in this case.

Btw, it seems EasyCLA is not working for any PRs in this repo.

Therefore, I have signed using the original nephio repo's PR EasyCLA "details" button.
(Since in that PR, there was one)

If I have made a mistake or anything goes wrong, please let me know.

@electrocucaracha
Copy link
Member

/check-cla

@liamfallon
Copy link
Member

/easycla

@liamfallon
Copy link
Member

/approve
/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Apr 16, 2024
@nephio-prow nephio-prow bot merged commit 7463d2f into nephio-project:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants