Skip to content

Conversation

@vjayaramrh
Copy link
Contributor

@vjayaramrh vjayaramrh commented Apr 16, 2025

This PR creates packages for installing the ironic components.
The fields of ConfigMap below are what needs to set depending on the environment.

apiVersion: v1
data:
CACHEURL: http://172.22.0.1/images
DEPLOY_KERNEL_URL: http://172.22.0.2:6180/images/ironic-python-agent.kernel
DEPLOY_RAMDISK_URL: http://172.22.0.2:6180/images/ironic-python-agent.initramfs
DHCP_RANGE: 172.22.0.10,172.22.0.100
HTTP_PORT: "6180"
IRONIC_ENDPOINT: http://172.22.0.2:6385/v1/
IRONIC_INSPECTOR_VLAN_INTERFACES: all
IRONIC_KERNEL_PARAMS: console=ttyS0
PROVISIONING_INTERFACE: eth2
USE_IRONIC_INSPECTOR: "false"
kind: ConfigMap
metadata:
name: baremetal-operator-ironic-bmo-configmap-hfkfbf2mhf
namespace: baremetal-operator-system

Fixes: nephio-project/nephio#903

@nephio-prow nephio-prow bot requested review from henderiw and s3wong April 16, 2025 02:08
@nephio-prow nephio-prow bot added the approved label Apr 16, 2025
@vjayaramrh vjayaramrh requested a review from arora-sagar April 16, 2025 02:08
@@ -0,0 +1,204 @@
apiVersion: v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vjayaramrh Can we add this as an independent yaml? It will be easy to read.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vjayaramrh Would this suggestion by @arora-sagar be possible to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is generated by the command kustomize build ironic-deployment/default > cluster-api-infrastructure-ironic.yaml and it would be error prone to do separate out manually and maintain it.

Copy link
Contributor

@gkumar78 gkumar78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

envFrom:
- configMapRef:
name: baremetal-operator-ironic-bmo-configmap-6cf9t7484b
image: quay.io/metal3-io/ironic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us point to specific image version instead of latest which is always moving target. I guess 29.0 was recent released version. Same change needed for all containers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, This file is generated from the command kustomize build ironic-deployment/default > cluster-api-infrastructure-ironic.yaml, let me ask the ironic K8S community how they handle image versions.

USE_IRONIC_INSPECTOR: "false"
kind: ConfigMap
metadata:
name: baremetal-operator-ironic-bmo-configmap-6cf9t7484b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid the last dynamic sequence of characters (6cf9t7484b) in this configmap name? Just baremetal-operator-ironic-bmo-configmap should be good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name was not put in there manually but generated as part of the command execution kustomize build ironic-deployment/default > cluster-api-infrastructure-ironic.yaml

@efiacor
Copy link
Collaborator

efiacor commented May 21, 2025

/approve
/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit c3d94d3 into nephio-project:main May 21, 2025
2 checks passed
@vjayaramrh vjayaramrh deleted the ironic branch May 21, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create nephio package to install the ironic components alongside the Baremetal operator

5 participants