-
Notifications
You must be signed in to change notification settings - Fork 40
catalog package for the ironic components #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,204 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vjayaramrh Can we add this as an independent yaml? It will be easy to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vjayaramrh Would this suggestion by @arora-sagar be possible to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is generated by the command kustomize build ironic-deployment/default > cluster-api-infrastructure-ironic.yaml and it would be error prone to do separate out manually and maintain it.
gkumar78
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
| envFrom: | ||
| - configMapRef: | ||
| name: baremetal-operator-ironic-bmo-configmap-6cf9t7484b | ||
| image: quay.io/metal3-io/ironic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us point to specific image version instead of latest which is always moving target. I guess 29.0 was recent released version. Same change needed for all containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, This file is generated from the command kustomize build ironic-deployment/default > cluster-api-infrastructure-ironic.yaml, let me ask the ironic K8S community how they handle image versions.
| USE_IRONIC_INSPECTOR: "false" | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: baremetal-operator-ironic-bmo-configmap-6cf9t7484b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid the last dynamic sequence of characters (6cf9t7484b) in this configmap name? Just baremetal-operator-ironic-bmo-configmap should be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name was not put in there manually but generated as part of the command execution kustomize build ironic-deployment/default > cluster-api-infrastructure-ironic.yaml
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, vjayaramrh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR creates packages for installing the ironic components.
The fields of ConfigMap below are what needs to set depending on the environment.
catalog/infra/capi/cluster-capi-infrastructure-ironic/cluster-api-infrastructure-ironic.yaml
Lines 1 to 16 in 1055a35
Fixes: nephio-project/nephio#903