Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codeblock): conceal ">", "<" delimiters #53

Merged
merged 3 commits into from
Oct 23, 2022
Merged

feat(codeblock): conceal ">", "<" delimiters #53

merged 3 commits into from
Oct 23, 2022

Conversation

justinmk
Copy link
Member

Problem:

  • ">" char node is not anonymous so it can't be concealed by queries.
  • whitespace after ">" is not a valid codeblock.
  • query does not define conceal for codeblock ">", "<" delimiters.
  • h3 does not allow atoms after tags.

Solution:

  • Constrain the (codeblock) rule.
  • Relax (h3) rule.

@justinmk
feat(codeblock): conceal ">", "<" delimiters
31fe4fd 
Problem:
- ">" char node is not anonymous so it can't be concealed by queries.
- whitespace after ">" is not a valid codeblock.
- query does not define conceal for codeblock ">", "<" delimiters.
- h3 does not allow atoms after tags.

Solution:
- Constrain the (codeblock) rule.
- Relax (h3) rule.
@justinmk
commit generated files
bded909
@justinmk
binding.gyp
2a743c2
@justinmk justinmk mentioned this pull request Oct 23, 2022
Closed
@justinmk justinmk merged commit 871498a into neovim:master Oct 23, 2022
@justinmk justinmk deleted the fixes branch October 23, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justinmk