fix: errors from single ' or | #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single apostrophes are found in various :help documents such as ":help 'fillchars'". They should be treated as plaintext.
justinmk
changed the title
justinmk
changed the title
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Oct 9, 2022
- Improve generated HTML by updating parser which includes fixes for single "'" and single "|": neovim/tree-sitter-vimdoc#31 - Updated parser also fixes the conceal issue for "help" highlight queries neovim/tree-sitter-vimdoc#23 by NOT including whitespace in nodes. - But this means we need to restore the getws() function which scrapes leading whitespace from the original input (buffer).
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Oct 9, 2022
- Improve generated HTML by updating parser which includes fixes for single "'" and single "|": neovim/tree-sitter-vimdoc#31 - Updated parser also fixes the conceal issue for "help" highlight queries neovim/tree-sitter-vimdoc#23 by NOT including whitespace in nodes. - But this means we need to restore the getws() function which scrapes leading whitespace from the original input (buffer).
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Oct 9, 2022
- Improve generated HTML by updating parser which includes fixes for single "'" and single "|": neovim/tree-sitter-vimdoc#31 - Updated parser also fixes the conceal issue for "help" highlight queries neovim/tree-sitter-vimdoc#23 by NOT including whitespace in nodes. - But this means we need to restore the getws() function which scrapes leading whitespace from the original input (buffer).
github-actions bot
pushed a commit
to neovim/neovim
that referenced
this pull request
Oct 12, 2022
- Improve generated HTML by updating parser which includes fixes for single "'" and single "|": neovim/tree-sitter-vimdoc#31 - Updated parser also fixes the conceal issue for "help" highlight queries neovim/tree-sitter-vimdoc#23 by NOT including whitespace in nodes. - But this means we need to restore the getws() function which scrapes leading whitespace from the original input (buffer). (cherry picked from commit a7a83bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
'causes errors, it should be plaintext|causes errors, it should be plaintextSolution:
Remove explicit whitespace patterns from the related
$.wordpatterns. Thisalso fixes #23 because it
turns out that defining a
$.wordchoice that captures (leading) whitespace causestreesitter to include whitespace in all/most nodes in the tree?