fix: codeblock without "<" consumes extra char #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
justinmk
commented
Sep 30, 2022
justinmk
commented
- fix: codeblock without "<" consumes extra char
- fix: headings after implicitly-terminated codeblock
Problem: If a codeblock does not have a terminating "<" char, it consumes the first char of the next token. Solution: Define (codeblock) only in terms of its lines; it doesn't need to look for its "end". Instead, add $._line_end_codeblock to the list of things that can terminate a (block).
Problem: `block` has no way to terminate just after an implicitly-terminated `codeblock`, so the next line is always parsed as a plain `line` instead of a heading (h1/h2/h3). Because headings and `block` both are top-level forms, this prevents headings from being recognized in this case. Solution: Change headings (h1/h2/h3) to be contained by `line`. They are no longer top-level.
justinmk
commented
Sep 30, 2022
| (h1 | ||
| (word) | ||
| (tag | ||
| (word)))) |
There was a problem hiding this comment.
h1/h2/h3 are no longer top-level elements, they are now contained by line. This is necessary because implicitly-terminated codeblock (without <) consumes blank lines (because codeblocks can have blank and empty lines), so there is no way for block to know when to terminate and allow other top-level elements to start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.