fix: return python interpreter exit status from pynvim-python #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: python interpreter exit status is ignored by pynvim-python. For example: ```console $ pynvim-python -c 'import sys; sys.exit(5)'; echo $? 0 ``` Solution: propagate the exit status from pynvim-python. Use `sys.exit()` to return the interpreter's exit status as found in `subprocess.run().returncode`: ```console $ pynvim-python -c 'import sys; sys.exit(5)'; echo $? 5 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: python interpreter exit status is ignored by pynvim-python.
For example:
Solution: propagate the exit status from pynvim-python.
Use
sys.exit()to return the interpreter's exit status as found insubprocess.run().returncode:Despite the number of times I read over this code, I'm sorry to say I failed to notice the expected
sys.exit()was missing. This week, I woke from a sound sleep in the middle of the night with the thought that I didn't remember seeingsys.exit(); I got up to check, and sure enough I'd left it off.