Skip to content

Add tox #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 12, 2017
Merged

Add tox #242

merged 4 commits into from
Jan 12, 2017

Conversation

heliomeiralins
Copy link
Contributor

No description provided.

@heliomeiralins heliomeiralins changed the title Add tox.ini file WIP - Add tox.ini file Jan 10, 2017
@heliomeiralins heliomeiralins force-pushed the add-tox branch 2 times, most recently from b858fa3 to 2dfaafb Compare January 11, 2017 00:43
@heliomeiralins heliomeiralins changed the title WIP - Add tox.ini file Add tox Jan 11, 2017
@heliomeiralins
Copy link
Contributor Author

So, this PR tests python3.6 in travis and now I guess we could bump a new version given #241 is necessary to run on python3.6.

@justinmk
Copy link
Member

Is it necessary to run the "flake" build on python 2 and 3? Perhaps we only need the "flake" build on python 3. That would eliminate one of the builds.

@heliomeiralins
Copy link
Contributor Author

I don't think it is. Django for example only uses flake on python3. django/tox.ini
I can change it to tox also.

@justinmk
Copy link
Member

justinmk commented Jan 12, 2017 •
edited
Loading

I guess just this needs to be deleted from travis.yml:

matrix
   include:
     - python: 2.7
       env: CI_TARGET=flake

@justinmk
Copy link
Member

LGTM. Ready?

@bfredl
Copy link
Member

bfredl commented Jan 12, 2017

we could bump a new version given #241 is necessary to run on python3.6.

👍 I will release a version after this PR.

@heliomeiralins
Copy link
Contributor Author

:shipit:

@justinmk justinmk merged commit 99a2150 into neovim:master Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heliomeiralins @justinmk @bfredl