feat(clangd): remove proto filetype support, reverting (#2125) #3959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The corresponding post was made in 2022, but we now have rich protobuf language servers and formatters such as [buf](https://github.com/bufbuild/buf). There are open hacks to getting around this by explicitly overriding the default settings, but it's more idiomatic to have sensible defaults in the go-to lsp repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2125
The corresponding post was made in 2022, but we now have rich protobuf language servers and formatters such as
buf. Buf already has their stuff registered with mason and nonels, so they're already well integrated into the neovim ecosystem.
There are open hacks to getting around this by explicitly overriding the default settings, but it's more idiomatic to have sensible defaults in the go-to lsp repo. (The current issue is that clangd will attach, fail to parse, then spam the file with bogus error messages).