feat(async): add run_job, a coroutine-less version of run_command
#3666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to port configurations to neovim 0.11
Merged
justinmk
reviewed
Apr 11, 2025
| local stdout = {} | ||
| local stderr = {} | ||
|
|
||
| local jobid = vim.fn.jobstart(cmd, { |
There was a problem hiding this comment.
Can vim.system be used instead?
There was a problem hiding this comment.
I think vim.system might actually be better, the syntax is easier. Maybe I could inline the calls and close this PR.
Why ? |
Well I don't know Go that much, but its configuration runs |
|
Closing as not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for neovim 0.11 port
3 configurations use
async.run_command, but this function cannot be used outside of a coroutine context. This is a replacement that's made exactly for thatNeeded for #3659