Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fennel-ls support #2247

Merged
merged 5 commits into from
Nov 20, 2022
Merged

feat: add fennel-ls support #2247

merged 5 commits into from
Nov 20, 2022

Conversation

gh-liu
Copy link
Contributor

@gh-liu gh-liu commented Nov 19, 2022

Untested on windows.

@glepnir
Copy link
Member

glepnir commented Nov 19, 2022

does this server not support windows?

lua/lspconfig/server_configurations/fennel-ls.lua Outdated Show resolved Hide resolved
lua/lspconfig/server_configurations/fennel-ls.lua Outdated Show resolved Hide resolved
lua/lspconfig/server_configurations/fennel-ls.lua Outdated Show resolved Hide resolved
lua/lspconfig/server_configurations/fennel-ls.lua Outdated Show resolved Hide resolved
@gh-liu
Copy link
Contributor Author

gh-liu commented Nov 19, 2022

does this server not support windows?

does this server not support windows?

I guess it's possible, but I haven't tried it yet.

gh-liu and others added 4 commits November 19, 2022 11:19
Co-authored-by: Raphael <glephunter@gmail.com>
Co-authored-by: Raphael <glephunter@gmail.com>
Co-authored-by: Raphael <glephunter@gmail.com>
Co-authored-by: Raphael <glephunter@gmail.com>
@glepnir
Copy link
Member

glepnir commented Nov 19, 2022

so we can simply add the server cmd in windows. if it not works fine we can fix it according the error message

local cmd = 'fennel-ls'
if vim.fn.has('win32') then
  cmd = { 'cmd.exe', '/C', 'fennel-ls'}
end

@gh-liu
Copy link
Contributor Author

gh-liu commented Nov 19, 2022

I have tried in wsl2, but it's not work.
The error in lsp.log is .../vim/lsp/rpc.lua:732 "rpc" "cmd.exe" "stderr" "'fennel-ls' is not recognized as an internal or external command,\r\noperable program or batch file.\r\n" , but I do not known how to compile is to a windows EXE file.

@glepnir
Copy link
Member

glepnir commented Nov 19, 2022

hmmm okay then just need fix the commit message.

@gh-liu
Copy link
Contributor Author

gh-liu commented Nov 19, 2022

hmmm okay then just need fix the commit message.

ok

@glepnir glepnir merged commit 16c8f45 into neovim:master Nov 20, 2022
@XeroOl
Copy link
Contributor

XeroOl commented Dec 16, 2022

The code in server_configurations.md is wrong.

require'lspconfig'.fennel-ls.setup{}    -- wrong
require'lspconfig'['fennel-ls'].setup{} -- fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants