Can't install via homebrew-neovim if luarocks path is set explicitly

[telemachus]

I believe that this is related to the following two issues, but I wanted to post it here as well, in case other people are seeing the same problems.

Related issues:

• Building neovim fails (lua module mpack not found) neovim#4573
• Build failures on OSX libmpack/libmpack#2

Failied build output:

$ brew install --HEAD neovim
==> Installing neovim from neovim/neovim
==> Cloning https://github.com/neovim/neovim.git
Cloning into '/Library/Caches/Homebrew/neovim--git'...
remote: Counting objects: 2041, done.
remote: Compressing objects: 100% (1897/1897), done.
remote: Total 2041 (delta 159), reused 1373 (delta 127), pack-reused 0
Receiving objects: 100% (2041/2041), 7.30 MiB | 4.41 MiB/s, done.
Resolving deltas: 100% (159/159), done.
Checking connectivity... done.
==> Checking out branch master
==> Downloading https://github.com/libuv/libuv/archive/v1.8.0.tar.gz
==> Downloading from https://codeload.github.com/libuv/libuv/tar.gz/v1.8.0
######################################################################## 100.0%
==> Downloading https://github.com/msgpack/msgpack-c/archive/cpp-1.0.0.tar.gz
==> Downloading from https://codeload.github.com/msgpack/msgpack-c/tar.gz/cpp-1.0.0
######################################################################## 100.0%
==> Downloading https://raw.githubusercontent.com/neovim/deps/master/opt/LuaJIT-2.0.4
######################################################################## 100.0%
==> Downloading https://github.com/keplerproject/luarocks/archive/5d8a16526573b36d5b2
==> Downloading from https://codeload.github.com/keplerproject/luarocks/tar.gz/5d8a16
######################################################################## 100.0%
==> Downloading https://github.com/mauke/unibilium/archive/v1.2.0.tar.gz
==> Downloading from https://codeload.github.com/mauke/unibilium/tar.gz/v1.2.0
######################################################################## 100.0%
==> Downloading http://www.leonerd.org.uk/code/libtermkey/libtermkey-0.18.tar.gz
######################################################################## 100.0%
==> Downloading https://github.com/neovim/libvterm/archive/1b745d29d45623aa8d22a7b928
==> Downloading from https://codeload.github.com/neovim/libvterm/tar.gz/1b745d29d4562
######################################################################## 100.0%
==> Downloading https://github.com/jemalloc/jemalloc/releases/download/4.0.2/jemalloc
==> Downloading from https://github-cloud.s3.amazonaws.com/releases/13310527/17afd0b4
######################################################################## 100.0%
==> Building third-party dependencies.
==> cmake ../third-party -DUSE_BUNDLED_BUSTED=OFF -DUSE_BUNDLED_LUV=OFF -DUSE_EXISTIN
==> make VERBOSE=1
==> Building Neovim.
==> cmake .. -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCM
Last 15 lines from /Users/telemachus/Library/Logs/Homebrew/neovim/03.cmake:
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE  
-- Checking Lua interpreter /tmp/neovim20160417-5070-l9l8zn/deps-build/usr/bin/luajit
-- [/tmp/neovim20160417-5070-l9l8zn/deps-build/usr/bin/luajit] The 'lpeg' lua package is required for building Neovim
-- Checking Lua interpreter /usr/local/bin/lua
-- [/usr/local/bin/lua] The 'mpack' lua package is required for building Neovim
CMake Error at CMakeLists.txt:390 (message):
  A suitable Lua interpreter was not found.


-- Configuring incomplete, errors occurred!
See also "/tmp/neovim20160417-5070-l9l8zn/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/neovim20160417-5070-l9l8zn/build/CMakeFiles/CMakeError.log".

READ THIS: https://git.io/brew-troubleshooting
If reporting this issue please do so at (not Homebrew/brew):
  https://github.com/neovim/homebrew-neovim/issues

These open issues may also help:
Error when trying to install neovim in my Ubuntu 14.04 virtual machine. https://github.com/neovim/homebrew-neovim/issues/134

[justinmk]

#147 (comment)

[telemachus]

@justinmk I've tried a full reinstall (including clearing the cache completely), and it does not help.

mpack currently doesn't install on OSX for me, and I suspect that's the underlying problem.

[justinmk]

Left a comment at libmpack/libmpack#2. I think we require one of luajit or lua 5.1 for now.

[telemachus]

luajit could still be trouble since if I'm reading the build output from above correctly, when it attempts to use luajit, that fails because of lpeg. (But maybe I'm misunderstanding what's happening at that point in the build.)

-- Checking Lua interpreter /tmp/neovim20160417-5070-l9l8zn/deps-build/usr/bin/luajit
-- [/tmp/neovim20160417-5070-l9l8zn/deps-build/usr/bin/luajit] The 'lpeg' lua package is required for building Neovim

[telemachus]

@justinmk Per your request in Gitter, here's a verbose log: https://gist.github.com/telemachus/fe078934942bdcc2a0e86319de5e1148

[telemachus]

After uninstalling everything related to Lua, I was finally able to build neovim. I'm still not sure what happened to my environment, but I'll close this for now.

[justinmk]

@telemachus Thanks for followup.

[telemachus]

@justinmk et al. I've just reopened this, because after some more testing I'm very confused.

Here's where things stand right now: I can install neovim, but only if I uninstall everything else related to Lua first.

I don't think that should be required, and obviously, the Travis CI testing won't catch it, since (I assume) each Travis build starts with a fresh clean image without a previous Lua install.

So, in a nutshell, my question is this: Is it expected that neovim should fail if you already have Lua installed on OSX? If not, what can I test in order to see what's wrong with my setup?

Thanks.

[jszakmeister]

So, in a nutshell, my question is this: Is it expected that neovim should fail if you already have Lua installed on OSX? If not, what can I test in order to see what's wrong with my setup?

Jumping in here real quick. I would say no, it's not expected. In fact, we got through some trouble to make sure that our deps are picked up before system ones.

Looking at your verbose log, it appears that something went wrong when checking for the necessary modules or the lpeg module was not built correctly for some reason:

-- Checking Lua interpreter /tmp/neovim-20160419-32334-17yn1fw/deps-build/usr/bin/luajit
-- [/tmp/neovim-20160419-32334-17yn1fw/deps-build/usr/bin/luajit] The 'lpeg' lua package is required for building Neovim
-- Checking Lua interpreter /usr/local/bin/lua
-- [/usr/local/bin/lua] The 'mpack' lua package is required for building Neovim
CMake Error at CMakeLists.txt:390 (message):
  A suitable Lua interpreter was not found.


-- Configuring incomplete, errors occurred!
See also "/tmp/neovim-20160419-32334-17yn1fw/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/neovim-20160419-32334-17yn1fw/build/CMakeFiles/CMakeError.log".

It tried to use our toolchain first, but something isn't right with the lpeg package. And it looks like it built:

/Applications/Xcode.app/Contents/Developer/usr/bin/make -f CMakeFiles/lpeg.dir/build.make CMakeFiles/lpeg.dir/depend
cd /tmp/neovim-20160419-32334-17yn1fw/deps-build && /usr/local/Cellar/cmake/3.5.2/bin/cmake -E cmake_depends "Unix Makefiles" /tmp/neovim-20160419-32334-17yn1fw/third-party /tmp/neovim-20160419-32334-17yn1fw/third-party /tmp/neovim-20160419-32334-17yn1fw/deps-build /tmp/neovim-20160419-32334-17yn1fw/deps-build /tmp/neovim-20160419-32334-17yn1fw/deps-build/CMakeFiles/lpeg.dir/DependInfo.cmake --color=
Dependee "/tmp/neovim-20160419-32334-17yn1fw/deps-build/CMakeFiles/lpeg.dir/DependInfo.cmake" is newer than depender "/tmp/neovim-20160419-32334-17yn1fw/deps-build/CMakeFiles/lpeg.dir/depend.internal".
Dependee "/tmp/neovim-20160419-32334-17yn1fw/deps-build/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/tmp/neovim-20160419-32334-17yn1fw/deps-build/CMakeFiles/lpeg.dir/depend.internal".
Scanning dependencies of target lpeg
/Applications/Xcode.app/Contents/Developer/usr/bin/make -f CMakeFiles/lpeg.dir/build.make CMakeFiles/lpeg.dir/build
[ 51%] Generating usr/lib/luarocks/rocks/lpeg
usr/bin/luarocks build lpeg CC=/usr/local/Library/ENV/4.3/clang LD=/usr/local/Library/ENV/4.3/clang
/usr/local/Library/ENV/4.3/clang -O2 -fPIC -I/tmp/neovim-20160419-32334-17yn1fw/deps-build/usr/include/luajit-2.0 -c lpcap.c -o lpcap.o
/usr/local/Library/ENV/4.3/clang -O2 -fPIC -I/tmp/neovim-20160419-32334-17yn1fw/deps-build/usr/include/luajit-2.0 -c lpcode.c -o lpcode.o
/usr/local/Library/ENV/4.3/clang -O2 -fPIC -I/tmp/neovim-20160419-32334-17yn1fw/deps-build/usr/include/luajit-2.0 -c lpprint.c -o lpprint.o
/usr/local/Library/ENV/4.3/clang -O2 -fPIC -I/tmp/neovim-20160419-32334-17yn1fw/deps-build/usr/include/luajit-2.0 -c lptree.c -o lptree.o
/usr/local/Library/ENV/4.3/clang -O2 -fPIC -I/tmp/neovim-20160419-32334-17yn1fw/deps-build/usr/include/luajit-2.0 -c lpvm.c -o lpvm.o
/usr/local/Library/ENV/4.3/clang -bundle -undefined dynamic_lookup -all_load -o lpeg.so -L/tmp/neovim-20160419-32334-17yn1fw/deps-build/usr/lib lpcap.o lpcode.o lpprint.o lptree.o lpvm.o
Updating manifest for /tmp/neovim-20160419-32334-17yn1fw/deps-build/usr/lib/luarocks/rocks
lpeg 1.0.0-1 is now built and installed in /tmp/neovim-20160419-32334-17yn1fw/deps-build/usr (license: MIT/X11)

So maybe something is wrong with our detection scheme or maybe lpeg is not being loaded correctly with the new toolchain. It could be that a dependency needs to be updated, or there is something that needs to be fixed upstream. I would start there first.