-
-
Notifications
You must be signed in to change notification settings - Fork 15
TASK: Modernize code and bump dependencies #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only support Neos 7.3 and 8.x+ and require at least PHP 7.4
By defining the resources as assoziative array instead of an indexed array its much easier to add custom styles or scripts to the module.
This prevents collisions between the hard CSS reset in the default stylesheet
We should define a new minor version when this is released as it's not breaking but has bumped dependencies. |
The largest part of the bundle are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter check fails in _add-redirect-form.css
on line 59. The import of @import "../vendor/datepicker";
seems a bit odd.
@Sebobo can we delete this or do we have to include something else?
Sorry for my missing review so far. Will take a look at the PR this evening! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, and it works!
924fc49
to
b2aa6f2
Compare
There was a reason due to specificity. So I disabled the style lint rule. |
What has changed: