Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Allow underscores in source uri #32

Merged
merged 2 commits into from
Oct 22, 2019

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Sep 23, 2019

WIthout this it’s not possible to redirect resources
without changing the configuration.

Depends on neos/redirecthandler#34

@Sebobo Sebobo added the bug label Sep 23, 2019
@Sebobo
Copy link
Member Author

Sebobo commented Sep 23, 2019

Should be adapted to require a new minimal version for the redirect handler package.

WIthout this it’s not possible to redirect resources
without changing the configuration.

Depends on neos/redirecthandler#34
@Sebobo Sebobo force-pushed the bugfix/allow-underscore-in-sourceuri branch from ebd8a2c to 999f425 Compare October 22, 2019 10:15
@Sebobo Sebobo marked this pull request as ready for review October 22, 2019 10:15
@Sebobo Sebobo requested a review from jonnitto October 22, 2019 10:15
Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it works as expected. Thanks!

@Sebobo Sebobo merged commit ad6f03d into master Oct 22, 2019
@Sebobo Sebobo deleted the bugfix/allow-underscore-in-sourceuri branch October 22, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants