BUGFIX: fallback to the first tab when tab index is out of bounds #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skurfuerst
reviewed
Sep 5, 2017
| @@ -73,13 +73,20 @@ export default class Tabs extends PureComponent { | |||
| ); | |||
| } | |||
|
|
|||
| getActiveTab() { | |||
There was a problem hiding this comment.
I'd call this "activeTabIndex"; and also change the state property to "activeTabIndex" - is more clear, wdyt?
There was a problem hiding this comment.
The problem with renaming state activeTab is that it has related prop activeTab, which is a part of component's API, and since we publish this package to npm and already version it, that would require a version bump... Frankly I'd just ignore it, but if you insist I can take care.
There was a problem hiding this comment.
OK then we keep it as is. Fine ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #826