BUGFIX: Speed up node tree copy actions #3984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don’t include recursive childnode info in copy action feedback which we don’t need for the node trees to work. Resolves: #3983
mhsdesign
approved these changes
Aug 18, 2025
mhsdesign
added a commit
that referenced
this pull request
Aug 20, 2025
See #3984 In Neos 9 the `$updateNodeInfo->recursive()` was added to `AbstractStructuralChange` and the `AbstractCopy` was removed. This change now removes the expensive recursive of `UpdateNodeInfo` as we dont need that for the Ui anymore.
mhsdesign
added a commit
that referenced
this pull request
Aug 20, 2025
…ng-recursive-node-fetching-in-response BUGFIX: Speed up node tree copy actions 9.0 port of #3984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t include recursive childnode info in copy action feedback which we don’t need for the node trees to work.
Both trees still work as before. Only difference is that uncollapsing the copied nodes might lazy load deeper nested nodes.
Resolves: #3983
Testcase:
Copying 4 documents with some content in the Neos.Demo
Response times
With recursive data: 4.4KB
Without recursive data: 2.5 KB
With more nested data:
Calls with recursive data
Calls without recursive data