FEATURE: improve performance for publish / discard workspaces #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... this ensures that during publishing of nodes, we do not fork sub-processes for event processing (for every event). This speeds up the system usually by at least factor 2-3 during these operations. It *could* have some side-effects if caches were not properly cleared, but at least I did not see any yet (and we run tests often with this flag). Resolves: neos/neos-development-collection#4285
mhsdesign
requested changes
Jul 7, 2023
There was a problem hiding this comment.
ill mark this as blocked until our discussion in neos is resolved: neos/neos-development-collection#4286 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neos part: neos/neos-development-collection#4286
... this ensures that during publishing of nodes, we do not fork sub-processes for event processing (for every event). This speeds up the system usually by at least factor 2-3 during these operations.
It could have some side-effects if caches were not properly cleared, but at least I did not see any yet (and we run tests often with this flag).
Resolves: neos/neos-development-collection#4285