Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix yarn npm auth token #3291

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

JamesAlias
Copy link
Contributor

@JamesAlias JamesAlias commented Dec 8, 2022

Fixes #3283

What I did
Use empty fallback for NPM_TOKEN env variable.

How I did it
Live with @ahaeslich.

How to verify it
yarn --version should not show missing NPM Token error.

@markusguenther markusguenther changed the title BUGFIX: #3283 Fix yarn npm auth token BUGFIX: Fix yarn npm auth token Dec 8, 2022
Copy link
Member

@markusguenther markusguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, and thanks for providing this patch and kudos to @Sebobo for bringing that up :)

@markusguenther markusguenther merged commit 5aacaa5 into 8.3 Dec 8, 2022
@markusguenther markusguenther deleted the bugfix-yarn-npm-auth-token branch December 8, 2022 10:41
markusguenther pushed a commit that referenced this pull request Dec 8, 2022
Co-authored-by: Robert Baruck <robert.baruck@sandstorm.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't require NPM_TOKEN locally
2 participants