Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Allow redirect to invisible nodes for preview #2557

Merged
merged 3 commits into from
Oct 29, 2019
Merged

BUGFIX: Allow redirect to invisible nodes for preview #2557

merged 3 commits into from
Oct 29, 2019

Conversation

kdambekalns
Copy link
Member

This allows the redirectToAction to receive invisible nodes to redirect
to.

See #2500 - this is part of a solution

@kdambekalns kdambekalns self-assigned this Sep 24, 2019
dimaip
dimaip approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@dimaip dimaip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by reading

@kdambekalns kdambekalns force-pushed the task/2500-redirect-to-invisible branch from 172b1e9 to 6db65da Compare September 24, 2019 15:03
@kdambekalns kdambekalns mentioned this pull request Sep 24, 2019
Merged
@kdambekalns
Copy link
Member Author

Note that this needs neos/neos-development-collection#2711 to work.

@TheLalaMan
Copy link

Would love to have that!

@kdambekalns
Copy link
Member Author

@dimaip Can you point me into some direction to understand why the e2e test fails?

@dimaip
Copy link
Contributor

dimaip commented Oct 23, 2019

Hey @kdambekalns, to start with 3.x branch should not ever be used, it has been renamed to 4.0.
If you want the bugfix to go to Neos 3.3 then target the 2.x branch, if Neos 4.0 then the 4.0 branch. Try to rebase it on top of the branch that you want to use, should work.

@kdambekalns kdambekalns changed the base branch from 3.x to 4.0 October 23, 2019 07:22
@kdambekalns kdambekalns reopened this Oct 23, 2019
@kdambekalns
BUGFIX: Allow redirect to invisible nodes for preview
88a38c2 
This allows the `redirectToAction` to receive invisible nodes to redirect
to.

See neos#2500 - this is part of a solution
@kdambekalns
TASK: For preview redirects, add showInvisible parameter
ad342c8
@kdambekalns kdambekalns force-pushed the task/2500-redirect-to-invisible branch from 806bd9f to ad342c8 Compare October 23, 2019 07:33
@kdambekalns
Copy link
Member Author

Trying with a "proper rebase" on 4.0 now…

@kdambekalns
Copy link
Member Author

@dimaip That didn't help… is that a CircleCI cache issue ("found cache from build 17" sound suspicious?)

@dimaip
Copy link
Contributor

dimaip commented Oct 23, 2019

Yup, it caches Neos distribution based on contents of this file: https://github.com/neos/neos-ui/blob/master/Tests/IntegrationTests/TestDistribution/composer.json#L3
If you want to flush it, just change that line.

@kdambekalns kdambekalns merged commit 3c6e92f into neos:4.0 Oct 29, 2019
@kdambekalns kdambekalns deleted the task/2500-redirect-to-invisible branch October 29, 2019 15:44
@dimaip
Copy link
Contributor

dimaip commented Nov 1, 2019

Hey @kdambekalns, but this bugfix makes neos-ui not to work with any existing versions of neos/neos, right? Are we allowed to do such things in a bugfix release?

@kdambekalns
Copy link
Member Author

It should not cause any more harm. The added parameter is ignored, and before all you got was an exception anyway, no?

@kdambekalns
Copy link
Member Author

But I'll check this later today…

@kdambekalns
Copy link
Member Author

Ah, now I see… Undefined class constant 'INVISIBLE_CONTENT_SHOWN' is what happens. Dang.

kdambekalns added a commit to kdambekalns/neos-ui that referenced this pull request Nov 1, 2019
@kdambekalns
BUGFIX: Avoid use of undefined constant
df30a77 
This fixes an error with the UI on earlier Neos versions that lack a
constant introduced to fix neos#2500.

See neos#2557
@kdambekalns kdambekalns mentioned this pull request Nov 1, 2019
Merged
dimaip pushed a commit that referenced this pull request Nov 1, 2019
@kdambekalns @dimaip
BUGFIX: Avoid use of undefined constant (#2575)
fce2ff8 
This fixes an error with the UI on earlier Neos versions that lack a
constant introduced to fix #2500.

See #2557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaip dimaip dimaip approved these changes

@daniellienert daniellienert Awaiting requested review from daniellienert

@grebaldi grebaldi Awaiting requested review from grebaldi

@markusguenther markusguenther Awaiting requested review from markusguenther

Assignees

@kdambekalns kdambekalns

Labels
Backend / Backend-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdambekalns @TheLalaMan @dimaip