TASK: Exchange yarn with make as build tool #1633
Conversation
mstruebing
changed the title
|
Hey Max, thanks! I'm not opinionated about tooling at all, I'm fine with whatever works, but... why make? I've never seen it used in JS projects... What advatages does it bring over plain npm scripts? |
mstruebing
force-pushed
the
make
branch
2 times, most recently
from
699e4d3 to
0ee407c
Compare
|
Rebased to remove |
|
Is this still WIP? |
|
This is still WIP because I didn't update the docs according to this change. I want at least one approval to this change from someone who has an opinion to not decide alone on our build stack. :) |
|
@dimaip @mstruebing i simply love it! |
|
@mstruebing so you get a +1 from @johannessteu and +0.(6) from me, merge it? |
|
@dimaip first adjust the documentation ;) I'm on it. |
mstruebing
changed the title
|
I'm done! :) |
| open a pull request on Github. When travis runs through merge it an tag a new | ||
| release on Github. | ||
|
|
||
| After that trigger jenkins with the new version. |
There was a problem hiding this comment.
Could Jenkins do everything, including make release?
There was a problem hiding this comment.
In general yeah. We need to give him access to master branch and should find some way to only commit stuff we expect to change
There was a problem hiding this comment.
Master is generally protected, I don't know how to change that especially only for jenkins, we should not be able to push into master.
references #1629
I would update the docs if we decide to merge it.
I would love to hear what you people think of this.