Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes in the page tree only show as hidden when they are selected #749

Closed
tobiasgruber opened this issue Jun 21, 2017 · 4 comments
Closed

Nodes in the page tree only show as hidden when they are selected #749

tobiasgruber opened this issue Jun 21, 2017 · 4 comments
Assignees
@skurfuerst
Labels
Bug Label to mark the change as bugfix
Milestone
1.0.0 must haves

Comments

@tobiasgruber
Copy link
Member

tobiasgruber commented Jun 21, 2017 •
edited by skurfuerst
Loading

<- must-have for 1.0.0

If a node is set to hidden it is currently displayed normally in the page tree. When it is selected it is updated to display with strike through.

When the page tree is loaded, hidden nodes should display correctly (struck through).
@tobiasgruber tobiasgruber added the Bug Label to mark the change as bugfix label Jun 21, 2017
@tobiasgruber tobiasgruber added this to the 1.0.0 must haves milestone Jun 21, 2017
@mstruebing
Copy link
Contributor

I can't reproduce it, are you on the latest version of neos and the ui package? Maybe it is fixed in between, could you check again?

@skurfuerst
Copy link
Member

@mstruebing I've seen it; quite sure it still exists.

  1. ensure page A is set to hidden.
  2. go to page B.
  3. reload the whole backend.
  4. ERROR: page A is not displayed as hidden.
  5. when selecting Page A (and thus fully loading it), it becomes crossed-out.

The error, I think is, that we do not send the hidden status in the Node Tree endpoint; but we should.

@skurfuerst skurfuerst mentioned this issue Jul 5, 2017
Closed
58 tasks
@tobiasgruber
Copy link
Member Author

Taken on our website with the new Beta 3: neos_reactui_beta3_hidden_nodes_in_tree_bug

@skurfuerst
Copy link
Member

OK, this breaks the system on quite some cases. Will fix this :)

@skurfuerst skurfuerst self-assigned this Jul 8, 2017
skurfuerst added a commit that referenced this issue Jul 8, 2017
@skurfuerst
BUGFIX: ensure the tree state does not override the current node state
78c81ac 
Resolves #749
@skurfuerst skurfuerst mentioned this issue Jul 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skurfuerst skurfuerst

Labels
Bug Label to mark the change as bugfix
Projects
None yet
Milestone
1.0.0 must haves
Development

No branches or pull requests
3 participants
@skurfuerst @mstruebing @tobiasgruber