!!! BUGFIX: Keep supertypes unset in supertypes unset #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No, the title is not an error. Here is what happens: - You define a node type and inherit from "Document" - In that NodeType unset a supertype declared in "Document" - Now inherit from that nodetype again, and whatever the unset supertype declared, will be back This is caused by how the inherited supertypes are read using the method getDeclaredSuperTypes, which only returns the used supertypes, not the ones not used - even if "actively not used". This change fixes that and is marked breaking because there might be things disappearing from your nodetypes, depending on the nesting of your hierarchy.
|
By analyzing the blame information on this pull request, we identified @radmiraal, @robertlemke and @skurfuerst to be potential reviewers |
|
That sounds reasonable indeed. |
|
Make sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No, the title is not an error. Here is what happens:
declared, will be back
This is caused by how the inherited supertypes are read using the method
getDeclaredSuperTypes, which only returns the used supertypes, not the
ones not used - even if "actively not used".
This change fixes that and is marked breaking because there might be things
disappearing from your nodetypes, depending on the nesting of your hierarchy.