Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Separate properties and references in Neos UI #5156

Merged
merged 7 commits into from
Jul 2, 2024
Merged

FEATURE: Separate properties and references in Neos UI #5156

merged 7 commits into from
Jul 2, 2024

Conversation

pKallert
Copy link
Contributor

@pKallert pKallert commented Jun 21, 2024 •
edited by mhsdesign
Loading

Review instructions
This will work together with https://github.com/neos/neos-ui/pull/3810/files - references are now no longer included in the properties, but will be used separately, just like in the config.

This also fixes the label translation afterwards

Followup / Cleanup for #4677
Solves parts of #4981

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Jun 21, 2024
@pKallert pKallert changed the title DRAFT: FEATURE: Separate properties and features in Neos UI DRAFT: FEATURE: Separate properties and references in Neos UI Jun 21, 2024
@pKallert pKallert changed the title DRAFT: FEATURE: Separate properties and references in Neos UI FEATURE: Separate properties and references in Neos UI Jun 21, 2024
@pKallert pKallert mentioned this pull request Jun 21, 2024
Merged
dlubitz
dlubitz approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mhsdesign
mhsdesign reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care ;)

Neos.ContentRepositoryRegistry/Classes/Configuration/NodeTypeEnrichmentService.php Show resolved Hide resolved
Neos.Neos/Classes/Service/NodeTypeSchemaBuilder.php Show resolved Hide resolved
Neos.ContentRepositoryRegistry/Classes/Configuration/NodeTypeEnrichmentService.php Outdated Show resolved Hide resolved
Neos.ContentRepositoryRegistry/Classes/Configuration/NodeTypeEnrichmentService.php Outdated Show resolved Hide resolved
@mhsdesign
Copy link
Member

Btw with these changes ClientEval code might also need to be migrated as node.properties.myReference will no longer work but its node.references.myReference ... we should document this

Also youre basically solving unknowingly the things here #4981 so thanks :D

@pKallert @mhsdesign
Fix: Spacing
06d7d52 
Co-authored-by: Marc Henry Schultz <85400359+mhsdesign@users.noreply.github.com>
@pKallert pKallert mentioned this pull request Jun 24, 2024
Open
@pKallert pKallert requested a review from mhsdesign June 30, 2024 08:01
mhsdesign
mhsdesign approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests, looks perfect now!

@pKallert pKallert merged commit 23f594b into neos:9.0 Jul 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

@dlubitz dlubitz dlubitz approved these changes

@mhsdesign mhsdesign mhsdesign approved these changes

Assignees
No one assigned
Labels
9.0 Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pKallert @mhsdesign @kitsunet @dlubitz