Skip to content

FEATURE: Allow the format avif for thumbnail generation. #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mficzel
Copy link
Member

@mficzel mficzel commented Oct 13, 2020

As with webp the format has to be supported by the library behind imagine aswell.
Currently avif is only supported by imagick > 7.0.10-25 and libheif > 1.7.0.

Resolves: #3132

@mficzel mficzel requested a review from jonnitto October 13, 2020 17:30
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by reading

@mficzel
Copy link
Member Author

mficzel commented Oct 14, 2020

@jonnitto please test wether this works. My imagick is probably not new enough an creates jpeg files with an avif ending which is what is to be expected for older imagick versions.

@jonnitto
Copy link
Member

Unfortunately, this will not work yet, the imagine/imagine package doesn't support avif yet. I created an issue on their repo

@markusguenther
Copy link
Member

Guess it will take time until imagine/imagine supports that because the say the GraphicsMagick does not support that and only a newer version of ImageMagick has the support.

@mficzel mficzel marked this pull request as draft November 19, 2020 09:35
@mficzel
Copy link
Member Author

mficzel commented Nov 19, 2020

Converted to draft until imagine has been updated

@markusguenther
Copy link
Member

Maybe that's also helpful for us :)
php/php-src#7026

@morsssss
Copy link

morsssss commented Aug 6, 2021

Indeed! AVIF support is now available in libgd now, and it is also set to be part of PHP 8.1.

@mficzel mficzel marked this pull request as ready for review October 8, 2021 18:10
@mficzel
Copy link
Member Author

mficzel commented Oct 8, 2021

Since php 8.1 and imagine support avif now we should pick this up again. We will probably have to check the imagine dependencies

@bwaidelich
Copy link
Member

@mficzel +1 for picking this one up again. I suggested this change for the 7.3 release. But I think the PR needs to be re-created against the current master

@mficzel mficzel self-assigned this Nov 18, 2021
As with `webp` the format has to be supported by the library behind imagine aswell.
Currently `avif` is only supported by imagick > 7.0.10-25 and libheif > 1.7.0.
@mficzel mficzel force-pushed the feature/allowAvifFileFormatForThumbnails branch from de38deb to 86fa289 Compare November 18, 2021 12:51
@mficzel
Copy link
Member Author

mficzel commented Nov 18, 2021

@bwaidelich rebased on master

@bwaidelich bwaidelich merged commit af6dc6d into neos:master Nov 19, 2021
@bwaidelich
Copy link
Member

Thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for AVIF format
6 participants