Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support keys / paths with special characters in quoted keys #107

Merged
merged 1 commit into from
Dec 9, 2015

Conversation

aertmann
Copy link
Contributor

@aertmann aertmann commented Oct 5, 2015

To allow for more flexible keys support for quoted keys is introduced.

Example::

foo."bar@baz" = "bla"
foo.'bar.baz' = "other"

Resolves: NEOS-1410

To allow for more flexible keys support for quoted keys is introduced.

Example::

  foo."bar@baz" = "bla"
  foo.'bar.baz' = "other"

Resolves: NEOS-1410
@aertmann
Copy link
Contributor Author

aertmann commented Oct 5, 2015

👍

@kitsunet
Copy link
Member

Woho, nice idea, I won't directly say yes because I need to think about it. Can quickly lead to pretty chaotic looking and confusing TS. I mean why would you want such a key? But I can imagine it could be useful. Did you check how much more complicated the new regex is and how it handles a forgotten quote?

@aertmann
Copy link
Contributor Author

Highly doubt it will be used for "chaotic looking and confusing TS", but rather allow more "special" keys which should have be allowed in the first place IMO. E.g. we rely on @action for routing, but TS doesn't support such keys without workarounds.

Didn't specifically check for a forgotten quote, but basically the parser wouldn't recognize it and throw an error. Not much difference from before without quotes.

@kitsunet
Copy link
Member

kitsunet commented Nov 5, 2015

I agree with this, thanks for the explanation :)

@skurfuerst
Copy link
Member

Hey Aske,

nice change! 👍 by reading!

All the best,
Sebastian

kdambekalns added a commit that referenced this pull request Dec 9, 2015
[FEATURE] Support keys / paths with special characters in quoted keys

To allow for more flexible keys support for quoted keys is introduced.

Example::

  foo."bar@baz" = "bla"
  foo.'bar.baz' = "other"

Resolves: NEOS-1410
@kdambekalns kdambekalns merged commit a7a5219 into neos:master Dec 9, 2015
@aertmann aertmann deleted the gerrit-41241 branch December 9, 2015 10:51
@aertmann
Copy link
Contributor Author

aertmann commented Dec 9, 2015

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants