Delete metaData node independent of realtimeExtraction setting#23
Open
gjwnc wants to merge 2 commits intoneos:masterfrom
Open
Delete metaData node independent of realtimeExtraction setting#23gjwnc wants to merge 2 commits intoneos:masterfrom
gjwnc wants to merge 2 commits intoneos:masterfrom
Conversation
kdambekalns
reviewed
Sep 26, 2019
Member
kdambekalns
left a comment
There was a problem hiding this comment.
Thanks, sounds very reasonable! I am just not 100% sure about the implementation… so I left some comments.
Contributor
Author
|
@daniellienert Do you have any concerns to prevent a merge? I'm using this fix in a fork for two years now and it works well. |
Member
|
@daniellienert To me this seems ok, but I wonder… maybe the whole idea of realtime extraction is to not do anything and instead rely on a cron job or the like to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one set's
Neos.MetaData.Extractor.realtimeExtraction.enabledto false in Settings.yaml, the signalassetRemovedis not handled. Thus the nodedata table still contains nodes which have properties where the metadata entry is linked to a resource which does not exist any more, e.g. from properties of such aNeos.MetaData:ImagenodeSo, this patch is about preventing possible inconsistencies in the nodedata table.
This commit, always handles the signal
assetRemovedusingExtractionManager::onAssetRemovedwhich signalsMetaDataCollectionUpdatedviaNeos\MetaData\MetaDataManager. Thus the asset's metadata node is removed and rebuilding the metadata is also prevented by usingonAssetRemoved.