TASK: Remove plow-js from PlaceholderInsert plugin #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusguenther
added
enhancement
dependencies
|
woohoo, thanks a lot :) I assume that this works as expected, otherwise we can always tweak it in a follow-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we changed the build stack in the Neos-UI to esbuild we are able to use the optional chaining (?.) operator in JavaScript. As the modern JavaScript is pretty powerful, we don’t need the helper methods from the plow-js library anymore.
The library served us well and has been deprecated, we also throw console messages when we still use the functions from plow-js. To prevent bloating the console with Neos packages, we should remove the usage also in our own plugins.
With this PR we use esbuild instead of webpack for the Plugin and drop plow-js.