Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! TASK: Deprecate concepts addQueryString and argumentsToBeExcludedFromQueryString #3352

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented May 20, 2024

in flows uri building APIs

See discussion at neos/neos-development-collection#5076

Affected Fluid viewhelpers

  • <f:form />
  • <f:link.action />
  • <f:uri.action />

Affected PHP APIs

  • UriBuilder::setAddQueryString
  • UriBuilder::setArgumentsToBeExcludedFromQueryString

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@kitsunet kitsunet merged commit 4750c46 into neos:9.0 May 20, 2024
7 checks passed
@mhsdesign mhsdesign deleted the task/deprecate-addQueryString-and-argumentsToBeExcludedFromQueryString branch May 21, 2024 05:55
@mhsdesign mhsdesign changed the title TASK: Deprecate concepts addQueryString and `argumentsToBeExcludedF… !!! TASK: Deprecate concepts addQueryString and argumentsToBeExcludedFromQueryString May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants