TASK: Revert "FEATURE: Easy injection of the active ServerRequest" #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts neos#2144 which introduced a class `ActiveServerRequestProvider` that allowed for easy injection of the active `ServerRequest`. Background: With the immutable nature of PSR-7 classes, the injected request might not reflect the latest state and the behavior would depend on the order in which the injection was executed. With the HTTP middlewares chain ```Http\RequestHandler::getHttpRequest()`` will always contain the "current" request. Related: neos#658
albe
approved these changes
Dec 2, 2020
markusguenther
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #2144 which introduced a class
ActiveServerRequestProviderthat allowed for easy injection of the active
ServerRequest.Background:
With the immutable nature of PSR-7 classes, the injected request might
not reflect the latest state and the behavior would depend on the
order in which the injection was executed.
With the HTTP middlewares chain ```Http\RequestHandler::getHttpRequest()``
will always contain the "current" request.
Related: #658