Fix usage of pg_waldump --ignore option. #418
Conversation
Previously, the --ignore option was only used when reading from a single file.
|
Let's add test with usage of Then it would be really easy to review this: some confirmation that this thing works and waldump is not on the critical path, so quick code read is enough |
src/bin/pg_waldump/pg_waldump.c
Outdated
| pg_fatal("could not stat file \"%s\"", fname); | ||
|
|
||
| /* Round up segment size to next power of 2 or 1MB */ | ||
| WalSegSz = Max(next_pow2_int(stat.st_size), 1024 * 1024); |
There was a problem hiding this comment.
I do not understand the logic here: we get file size and then round it on power of two.
Either segment file has valid size and there is no need to align it, either it can bar smaller than segment size just because only some part of this segment was written, but in this case alignment on power of two will not help.
There was a problem hiding this comment.
Fixed.
This shouldn't be an issue for neon, because we always write full segment, even for our special segment 0.
Previously, the --ignore option was only used when reading from a single file.
Previously, the --ignore option was only used when reading from a single file.
With this PR
pg_waldump -iis enough to open any neon WAL segments