Skip to content

Add comment explaining why it is safe to use FirstNormalTransactionXid for oldestActiveXid while replica startup #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2024
Merged

Add comment explaining why it is safe to use FirstNormalTransactionXid for oldestActiveXid while replica startup #387

merged 1 commit into from
Feb 22, 2024

Conversation

knizhnik
Copy link

No description provided.

Add comment explaining why it is safe to use FirstNormalTransactionXi…
cc98378 
…d for oldestActiveXid while replica startup
@knizhnik knizhnik merged commit 67240b5 into REL_16_STABLE_neon Feb 22, 2024
@knizhnik knizhnik deleted the oldest_active_xid_v16 branch February 22, 2024 19:52
skyzh added a commit that referenced this pull request Mar 22, 2024
@skyzh
Revert "Add comment explaining why it is safe to use FirstNormalTrans…
d9d08fa 
…actionXid for oldestActiveXid while replica startup (#387)"

This reverts commit 67240b5.
skyzh added a commit that referenced this pull request Mar 22, 2024
@skyzh
Revert IsPrimaryAlive checks (#402)
3946b2e 
* Revert "Add comment explaining why it is safe to use FirstNormalTransactionXid for oldestActiveXid while replica startup (#387)"

This reverts commit 67240b5.

* Revert "Set wasShutdown=true during hot-standby replica startup only when primary is not alive (#363)"

This reverts commit 61c280c.
tristan957 pushed a commit that referenced this pull request May 10, 2024
@knizhnik @tristan957
Add comment explaining why it is safe to use FirstNormalTransactionXi…
facc780 
…d for oldestActiveXid while replica startup (#387)

Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
tristan957 pushed a commit that referenced this pull request May 10, 2024
@skyzh @tristan957
Revert IsPrimaryAlive checks (#402)
e49bbaa 
* Revert "Add comment explaining why it is safe to use FirstNormalTransactionXid for oldestActiveXid while replica startup (#387)"

This reverts commit 67240b5.

* Revert "Set wasShutdown=true during hot-standby replica startup only when primary is not alive (#363)"

This reverts commit 61c280c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubennikovaav lubennikovaav lubennikovaav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knizhnik @lubennikovaav