Skip to content

Add check for NULL for malloc in InternalIpcMemoryCreate #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Add check for NULL for malloc in InternalIpcMemoryCreate #173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05b52ba
Add check for NULL for malloc in InternalIpcMemoryCreate
knizhnik Jun 7, 2022
004452a
apply pgindent
knizhnik Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/backend/port/sysv_shmem.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,22 @@ InternalIpcMemoryCreate(IpcMemoryKey memKey, Size size)
}
}
#endif

/*
* NEON: do not create shared memory segments for single user wal redo postgres.
* Many spawned instances of wal redo may exhaust kernel.shmmni
* NEON: do not create shared memory segments for single user wal redo
* postgres. Many spawned instances of wal redo may exhaust kernel.shmmni
*/
if (am_wal_redo_postgres)
return valloc(size);
{
void *ptr = malloc(size);

if (ptr == NULL)
{
ereport(FATAL,
(errmsg("could not create shared memory segment with size %zu for WAL redo process", size)));
}
return ptr;
}
shmid = shmget(memKey, size, IPC_CREAT | IPC_EXCL | IPCProtection);

if (shmid < 0)
Expand Down