compact_level0_phase1: remove final traces of value access mode config #8935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problame
changed the title
refs #8184 Our staging and production `pageserver.toml` doesn't contain this field anymore. It was already being ignored by the last release.
problame
force-pushed
the
problame/compaction-pagecache-bypass-remove-config-field
branch
from
65308b7
to
8a9e666
Compare
4977 tests run: 4813 passed, 0 failed, 164 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
1092f8a at 2024-09-23T10:43:05.225Z :recycle: |
Base automatically changed from
problame/compaction-pagecache-bypass-remove-page-cached-blob-io-code-but-accept-config
to
main
September 6, 2024 08:58
…agecache-bypass-remove-config-field
skyzh
approved these changes
Sep 20, 2024
…agecache-bypass-remove-config-field
problame
deleted the
problame/compaction-pagecache-bypass-remove-config-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8184
stacked atop #8934
This PR changes from ignoring the config field to rejecting configs that contain it.
PR https://github.com/neondatabase/infra/pull/1903 removes the field usage from
pageserver.toml.It rolls into prod sooner or in the same release as this PR.